-
Bug
-
Resolution: Unresolved
-
Medium
-
None
-
None
-
None
With most of the warnings now fixed, there's just one outstanding before we can enable warnings-as-errors - an issue in TestParticlesToLevelSet. I had a quick look but couldn't figure out a simple solution to this one. pcucka, do you have time to look into how we can best solve this issue?
In file included from unittest/TestParticlesToLevelSet.cc:33: In file included from ../openvdb/openvdb.h:39: ./Grid.h:1358:57: warning: implicit conversion turns floating-point number into integer: 'float' to 'const bool' [-Wfloat-conversion] this->tree().prune(ValueType(zeroVal<ValueType>() + tolerance)); ~ ^~~~~~~~~ ./Grid.h:549:14: note: in instantiation of member function 'openvdb::v6_0::Grid<openvdb::v6_0::tree::Tree<openvdb::v6_0::tree::RootNode<openvdb::v6_0::tree::InternalNode<openvdb::v6_0::tree::InternalNode<openvdb::v6_0::tree::LeafNode<openvdb::v6_0::tools::p2ls_internal::BlindData<bool, unsigned long>, 3>, 4>, 5> > > >::pruneGrid' requested here explicit Grid(const ValueType& background); ^ ../openvdb/tools/ParticlesToLevelSet.h:330:26: note: in instantiation of member function 'openvdb::v6_0::Grid<openvdb::v6_0::tree::Tree<openvdb::v6_0::tree::RootNode<openvdb::v6_0::tree::InternalNode<openvdb::v6_0::tree::InternalNode<openvdb::v6_0::tree::LeafNode<openvdb::v6_0::tools::p2ls_internal::BlindData<bool, unsigned long>, 3>, 4>, 5> > > >::Grid' requested here mBlindGrid = new BlindGridType(BlindType(grid.background())); ^ ../openvdb/tools/ParticlesToLevelSet.h:1020:32: note: in instantiation of member function 'openvdb::v6_0::tools::ParticlesToLevelSet<openvdb::v6_0::Grid<openvdb::v6_0::tree::Tree<openvdb::v6_0::tree::RootNode<openvdb::v6_0::tree::InternalNode<openvdb::v6_0::tree::InternalNode<openvdb::v6_0::tree::LeafNode<openvdb::v6_0::ValueMask, 3>, 4>, 5> > > >, void, openvdb::v6_0::util::NullInterrupter>::ParticlesToLevelSet' requested here ParticlesToLevelSet<GridT> p2ls(grid, interrupt); ^ unittest/TestParticlesToLevelSet.cc:489:16: note: in instantiation of function template specialization 'openvdb::v6_0::tools::particlesToMask<openvdb::v6_0::Grid<openvdb::v6_0::tree::Tree<openvdb::v6_0::tree::RootNode<openvdb::v6_0::tree::InternalNode<openvdb::v6_0::tree::InternalNode<openvdb::v6_0::tree::LeafNode<openvdb::v6_0::ValueMask, 3>, 4>, 5> > > >, MyParticleList, openvdb::v6_0::util::NullInterrupter>' requested here tools::particlesToMask(pa, *mask);
https://travis-ci.org/AcademySoftwareFoundation/openvdb/jobs/487489603
- blocks
-
OVDB-15 Enable warnings as errors
- Done